RFR: 8265518: C1: Intrinsic support for Preconditions.checkIndex [v5]
yyang at openjdk.java.net
Thu Apr 29 10:16:19 UTC 2021
> The JDK codebase re-created many variants of checkIndex(`grep -I -r 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which annotated with @IntrinsicCandidate and it only has a corresponding C1 intrinsic version.
> In fact, there is an utility method `jdk.internal.util.Preconditions.checkIndex`(wrapped by java.lang.Objects.checkIndex) that behaves the same as these variants of checkIndex, we can replace these re-created variants of checkIndex by Objects.checkIndex, it would significantly reduce duplicated code and enjoys performance improvement because Preconditions.checkIndex is @IntrinsicCandidate and it has a corresponding intrinsic method in HotSpot.
> But, the problem is currently HotSpot only implements the C2 version of Preconditions.checkIndex. To reuse it global-widely in JDK code, I think we can firstly implement its C1 counterpart. There are also a few kinds of stuff we can do later:
> 1. Replace all variants of checkIndex by Objects.checkIndex in the whole JDK codebase.
> 2. Remove Buffer.checkIndex and obsolete/deprecate InlineNIOCheckIndex flag
> Testing: cds, compiler and jdk
Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
AssertionError when expected exception was not thrown
- all: https://git.openjdk.java.net/jdk/pull/3615/files
- new: https://git.openjdk.java.net/jdk/pull/3615/files/bbdf4b9e..1a96be7e
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3615&range=04
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3615&range=03-04
Stats: 8 lines in 1 file changed: 5 ins; 0 del; 3 mod
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3615/head:pull/3615
More information about the core-libs-dev