RFR: 4926314: Optimize Reader.read(CharBuffer)

Philippe Marschall kustos at gmx.net
Tue Jan 5 17:53:06 UTC 2021

On 05.01.21 01:53, Brian Burkhalter wrote:
> ...
> I changed the JBS issue summary to match the title of this PR so that integration blocker is removed.

Thank you.

> How does the performance of `InputStreamReader.read(CharBuffer)` compare for the case where only the change to `Reader` is made versus if all your proposed changes are applied?

I can look into this, this will take a moment. I guess it would also
make sense to have a comparison with a version that does intermediate
heap allocation for off-heap buffers in InputStreamReader#read(CharBuffer).

> Some kind of specific test should likely be included.

Sure. The existing tests in this area seem to be #main-based. Would you
prefer #main based tests or TestNG tests?

> Note that the more recent copyright year is now 2021.

Indeed it is, fixed.


More information about the core-libs-dev mailing list