RFR: 4926314: Optimize Reader.read(CharBuffer)

Brian Burkhalter brian.burkhalter at oracle.com
Tue Jan 5 18:08:19 UTC 2021

> On Jan 5, 2021, at 9:53 AM, Philippe Marschall <kustos at gmx.net> wrote:
>> How does the performance of `InputStreamReader.read(CharBuffer)` compare for the case where only the change to `Reader` is made versus if all your proposed changes are applied?
> I can look into this, this will take a moment. I guess it would also
> make sense to have a comparison with a version that does intermediate
> heap allocation for off-heap buffers in InputStreamReader#read(CharBuffer).

If you like. I was just wondering whether the change to Reader.read(CharBuffer) would be enough.

>> Some kind of specific test should likely be included.
> Sure. The existing tests in this area seem to be #main-based. Would you
> prefer #main based tests or TestNG tests?

For new tests we seem to be preferring Tests NG.

>> Note that the more recent copyright year is now 2021.
> Indeed it is, fixed.



More information about the core-libs-dev mailing list