RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v2]

Attila Szegedi attila at openjdk.java.net
Sun Jan 10 20:01:56 UTC 2021

On Sun, 10 Jan 2021 16:35:17 GMT, Johannes Kuhn <github.com+652983+DasBrain at openjdk.org> wrote:

>> Simple fix - one line change: https://openjdk.github.io/cr/?repo=jdk&pr=2000&range=00#sdiff-0.
>> Most of the changes come from an additional test that fails without this fix:
>>      Error: Unable to load main class somelib.test.TestMain in module somelib
>>     	java.lang.IllegalAccessError: superclass access check failed: class somelib.test.TestMain (in module somelib) cannot access class java.lang.Object (in module java.base) because module java.base does not export java.lang to module somelib
>> As described in JDK-8259395.
>> You can view the output of the test without patch here: https://github.com/DasBrain/jdk/runs/1668078245
>> Thanks to @AlanBateman for pointing out the right fix.
> Johannes Kuhn has updated the pull request incrementally with one additional commit since the last revision:
>   Move tests to test/jdk/tools/launcher/modules/patch/automatic.

Looks good aside from that one pesky missing newline.

test/jdk/tools/launcher/modules/patch/automatic/somelib/somelib/Dummy.java line 30:

> 28:         return true;
> 29:     }
> 30: }

No newline at the end of the file. Funny that the whitespace checker doesn't catch this.


Changes requested by attila (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2000

More information about the core-libs-dev mailing list