RFR: 8249867: xml declaration is not followed by a newline
joehw at openjdk.java.net
Tue Jan 12 23:27:00 UTC 2021
On Tue, 12 Jan 2021 21:25:54 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Please review a patch to add an explicit control over whether a newline should be added after the XML header. This is done by adding a DOM LSSerializer property "jdk-is-standalone" and System property "jdk.xml.isStandalone".
>> This change addresses an incompatibility introduced during 7u4 as an update to Xalan 2.7.1.
> When setting the fDOMConfigProperties is the difference between simple values of "yes" and "no" and the values of DOMConstants.DOM3_EXPLICIT_TRUE/FALSE significant?
The DOMConfigProperties differentiate "Explicit" values from the default ones. DOM3_EXPLICIT_TRUE/FALSE has a string form: explicit:yes/explicit:no, while the default ones default:yes/default:no. In some cases (for some parameters), default values are handled differently from the explicit ones.
In this case, it's not significant for the new property as to how it was processed. I merely followed the existing practice and mechanism to align with the existing parameters.
More information about the core-libs-dev