RFR: 8259947: (fs) Optimize UnixPath.encode implementation [v2]

Claes Redestad redestad at openjdk.java.net
Tue Jan 19 12:02:13 UTC 2021

> This patch improves `UnixPath.encode` by reusing `JLA.getBytesNoRepl` (which has fast-paths for common encoding) and avoiding a `toCharArray` call on the input by refactoring the `normalizeNativePath` code to operate on `String`. This might have a cost on files on Mac that need additional native normalization.
> This removes another `ThreadLocal` and a source of `SoftReference`s. Together with the UTF-8 fast-path my UTF-8 encoded file system see substantial speed-ups in a trivial `new File(str).toPath()` microbenchmark.

Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:

  Fold ToPath into FileOpen, add root benchmarks to keep mix comparable


  - all: https://git.openjdk.java.net/jdk/pull/2135/files
  - new: https://git.openjdk.java.net/jdk/pull/2135/files/27a55ee0..18c3105b

 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2135&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2135&range=00-01

  Stats: 128 lines in 2 files changed: 50 ins; 72 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2135.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2135/head:pull/2135

PR: https://git.openjdk.java.net/jdk/pull/2135

More information about the core-libs-dev mailing list