RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v4]

Johannes Kuhn github.com+652983+dasbrain at openjdk.java.net
Tue Jan 19 23:06:20 UTC 2021

> Simple fix - one line change: https://openjdk.github.io/cr/?repo=jdk&pr=2000&range=00#sdiff-0.
> Most of the changes come from an additional test that fails without this fix:
>      Error: Unable to load main class somelib.test.TestMain in module somelib
>     	java.lang.IllegalAccessError: superclass access check failed: class somelib.test.TestMain (in module somelib) cannot access class java.lang.Object (in module java.base) because module java.base does not export java.lang to module somelib
> As described in JDK-8259395.
> You can view the output of the test without patch here: https://github.com/DasBrain/jdk/runs/1668078245
> Thanks to @AlanBateman for pointing out the right fix.

Johannes Kuhn has updated the pull request incrementally with one additional commit since the last revision:

  Implement more tests.


  - all: https://git.openjdk.java.net/jdk/pull/2000/files
  - new: https://git.openjdk.java.net/jdk/pull/2000/files/7c2ed088..fc3b2ac0

 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2000&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2000&range=02-03

  Stats: 388 lines in 10 files changed: 316 ins; 54 del; 18 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2000.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2000/head:pull/2000

PR: https://git.openjdk.java.net/jdk/pull/2000

More information about the core-libs-dev mailing list