Integrated: 8259867: Move encoding checks into ZipCoder

eirbjo at
Wed Jan 20 12:05:00 UTC 2021

On Sat, 16 Jan 2021 17:49:38 GMT, eirbjo < at> wrote:

> ZipFile.Source.initCEN verifies that entry names are encoding into bytes valid in the entry's encoding. It does so by calling encoding-specific checking methods, so it also needs to determine which check method to call for each entry.
> By moving the encoding-variant checks into ZipCoder, initCEN can instead simply call ZipCoder.checkEncoding. This makes the code easier to follow and also removes a duplication of flag checking logic found in zipCoderForPos.

This pull request has now been integrated.

Changeset: 05294802
Author:    Eirik Bjorsnos <eirbjo at>
Committer: Claes Redestad <redestad at>
Stats:     58 lines in 2 files changed: 27 ins; 28 del; 3 mod

8259867: Move encoding checks into ZipCoder

Reviewed-by: redestad, lancea



More information about the core-libs-dev mailing list