RFR: 8260010: UTF8ZipCoder not thread-safe since JDK-8243469 [v2]

Lance Andersen lancea at openjdk.java.net
Wed Jan 20 19:51:55 UTC 2021

On Wed, 20 Jan 2021 13:03:04 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> This patch resolves a thread-safety issue where the singleton UTF8ZipCoder is erroneously using a shared CharsetDecoder when the fast-path fails. It needs to go via JLA.newStringUTF8NoRepl like before JDK-8243469
>> This should resolve a rare issue when doing a lot of jar scanning in parallel on jar/zip files (with at least some non-ASCII entries), but I've not managed to create a test that reliably reproduce the issue.
> Claes Redestad has updated the pull request incrementally with three additional commits since the last revision:
>  - Reuse normalizedHash(String)
>  - copyright
>  - Don't use No Replace variant to calculate hash, more fixes

I think the changes look OK.


Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2163

More information about the core-libs-dev mailing list