RFR: 8259922 MethodHandles.collectArguments does not follow its documentation [v2]

Mandy Chung mchung at openjdk.java.net
Fri Jan 22 00:47:49 UTC 2021

On Fri, 22 Jan 2021 00:33:16 GMT, Johannes Kuhn <github.com+652983+DasBrain at openjdk.org> wrote:

>> Add explicit range check to `MethodHandles.collectArgumentsCheck`.  
>> Added test case that exercises all cases.
>> This is a behavioral change, from throwing an unspecified exception to throwing an IllegalArgumentException, as specified.  
>> No spec change needed, as the IllegalArgumentException is already specified to be thrown in those cases.
>> Feel free to suggest a better place for the tests.
> Johannes Kuhn has updated the pull request incrementally with one additional commit since the last revision:
>   Implement suggestions by Mandy Chung.

Looks good.  What tests have you ran?


Marked as reviewed by mchung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2171

More information about the core-libs-dev mailing list