RFR: 8259707: LDAP channel binding does not work with StartTLS extension [v3]
aefimov at openjdk.java.net
Fri Jan 22 11:25:43 UTC 2021
On Thu, 21 Jan 2021 19:57:04 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> Add comments and volatile modifier for tlsHandshakeListener
The latest changes look good to me.
Thanks for handling a case of sequential StartTLS requests on one LDAP context and running the modified test. I've also checked that existing LDAP tests shows no failures with the proposed changed.
You might also want to update last modification years to `2021` in both files.
Marked as reviewed by aefimov (Committer).
More information about the core-libs-dev