RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java

Brent Christian bchristi at openjdk.java.net
Fri Jan 22 20:27:40 UTC 2021

On Fri, 22 Jan 2021 16:57:41 GMT, Mahendra Chhipa <github.com+34924738+mahendrachhipa at openjdk.org> wrote:

>> Can this be done all in `EnclosingClassTest.java`, without a new `RunEnclosingClassTest.java`?
>> Adding the `@BeforeClass` and `@AfterClass` methods to what's there, you may just need to 
>> change the `test()` calls to use reflection - something along the lines of: 
>>> test(`Class.forName("EnclosingClass").getDeclaredConstructor().newInstance());`
> Review comments implemented.

Can the new code be added to the existing `NonJavaNames.java` instead of adding a new `NonJavaNameTest.java` file?


PR: https://git.openjdk.java.net/jdk/pull/2170

More information about the core-libs-dev mailing list