RFR: 8252412: [macos11] system dynamic libraries removed from filesystem [v2]
valeriep at openjdk.java.net
Sat Jan 23 02:05:42 UTC 2021
On Fri, 22 Jan 2021 22:55:22 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Ok, I see Java_sun_security_smartcardio_PlatformPCSC_initialize does dlopen using the 'jLibName' (string) obtained from getLibraryName() and throws IOException if dlopen fails. The change seems safe enough.
>> I'm wondering if you want to check the file first then check the parent directory if the file does not exist. Not sure if that's a little more optimal on older macos, so I'll leave that to you to decide.
>> For the jtreg test, how about converting Dominik's TestPCSC? As the file is a shared for 'unix' platforms, it feels safer at least with some level of unit test. Could you please give some more contexts about the functionalities associated with PCSC are broken on macos?
> Martin and I had an off-line chat and Martin convinced me that the existing jtreg tests (such as test/jdk/javax/smartcardio and test/jdk/sun/security/smartcardio are sufficient) to cover the case.
Right, existing tests should cover this already since running the test requires that the library must be loaded.
Changes look fine, thanks for fixing this.
Kind of surprised the existing filtering didn't catch this as security-related changes and send this to security group for review.
More information about the core-libs-dev