RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]
vkempik at openjdk.java.net
Mon Jan 25 13:33:47 UTC 2021
On Mon, 25 Jan 2021 13:18:34 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional commits since the last revision:
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
> make/common/NativeCompilation.gmk line 1180:
>> 1178: # silently fail otherwise.
>> 1179: ifneq ($(CODESIGN), )
>> 1180: $(CODESIGN) -f -s "$(MACOSX_CODESIGN_IDENTITY)" --timestamp --options runtime \
> What does -f do, and is it needed for macos-x64 as well?
-f - replace signature if it's present, if not - just sign as usual
macos-aarch64 binaries always have adhoc signature, so need to replace it.
> make/modules/jdk.hotspot.agent/Lib.gmk line 34:
>> 33: else ifeq ($(call isTargetOs, macosx), true)
>> 34: SA_CFLAGS := -D_GNU_SOURCE -mno-omit-leaf-frame-pointer \
> Is this really proper for macos-x64? I thought we used -Damd64 as a marker for all macos-x64 C/C++ files. (Most files get their flags from the common setup in configure, but SA is a different beast due to historical reasons).
@luhenry , could you please check this comment, I think SA-agent was MS's job here.
More information about the core-libs-dev