RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

Bernhard Urban-Forster burban at openjdk.java.net
Mon Jan 25 16:02:45 UTC 2021

On Mon, 25 Jan 2021 13:30:55 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> make/modules/jdk.hotspot.agent/Lib.gmk line 34:
>>> 32: 
>>> 33: else ifeq ($(call isTargetOs, macosx), true)
>>> 34:   SA_CFLAGS := -D_GNU_SOURCE -mno-omit-leaf-frame-pointer \
>> Is this really proper for macos-x64? I thought we used -Damd64 as a marker for all macos-x64 C/C++ files. (Most files get their flags from the common setup in configure, but SA is a different beast due to historical reasons).
> @luhenry , could you please check this comment, I think SA-agent was MS's job here.

The target is identified by the header file now:

Do you think there is any problem with this approach?


PR: https://git.openjdk.java.net/jdk/pull/2200

More information about the core-libs-dev mailing list