RFR: 8260406: Do not copy pure java source code to gensrc
alanb at openjdk.java.net
Tue Jan 26 11:48:40 UTC 2021
On Tue, 26 Jan 2021 10:35:03 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> For java.base gensrc we do the following:
> # Copy two Java files that need no preprocessing.
> $(SUPPORT_OUTPUTDIR)/gensrc/java.base/java/lang/%.java: $(CHARACTERDATA_TEMPLATES)/%.java.template
> $(call LogInfo, Generating $(@F))
> $(call install-file)
> GENSRC_CHARACTERDATA += $(SUPPORT_OUTPUTDIR)/gensrc/java.base/java/lang/CharacterDataUndefined.java \
> What this means is that we have two "template" files that are just compiled as java files, but only after being copied to gensrc. :-)
> We should just rename these files to java and move them to the normal source directory.
Good. I notice the comment in both source files says "Java.lang.Character" rather than "java.lang.Character", probably should fix that at some point.
Marked as reviewed by alanb (Reviewer).
More information about the core-libs-dev