RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v4]
akozlov at openjdk.java.net
Tue Jan 26 15:06:14 UTC 2021
On Mon, 25 Jan 2021 10:00:20 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> I like the suggestion. For the defense, new functions were made this way intentionally, to match existing `pass_int`, `pass_long`,.. I take your comment as a blessing to fix all of them. But I feel that refactoring of existing code should go in a separate commit. Especially after `pass_int` used `ldr/str` instead of `ldrw/strw`, which looks wrong. https://github.com/openjdk/jdk/pull/2200/files#diff-1ff58ce70aeea7e9842d34e8d8fd9c94dd91182999d455618b2a171efd8f742cL87-R122
> This is new code, and it should not repeat the mistakes of the past. There's no need to refactor the similar existing code as part of this patch.
Makes sense, I've reverted changes in the old code but will propose them in the separate PR shortly.
More information about the core-libs-dev