RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]
vkempik at openjdk.java.net
Tue Jan 26 16:09:50 UTC 2021
On Mon, 25 Jan 2021 17:43:22 GMT, Phil Race <prr at openjdk.org> wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional commits since the last revision:
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
> src/java.desktop/share/native/libharfbuzz/hb-common.h line 113:
>> 112: #define HB_TAG(c1,c2,c3,c4) ((hb_tag_t)((((uint32_t)(c1)&0xFF)<<24)|(((uint32_t)(c2)&0xFF)<<16)|(((uint32_t)(c3)&0xFF)<<8)|((uint32_t)(c4)&0xFF)))
>> 113: #define HB_UNTAG(tag) (char)(((tag)>>24)&0xFF), (char)(((tag)>>16)&0xFF), (char)(((tag)>>8)&0xFF), (char)((tag)&0xFF)
> I need a robust explanation of these changes.
> They are not mentioned, nor are they in upstream harfbuzz.
> Likely these should be pushed to upstream first if there is a reason for them.
@lewurm This and other harfbuzz changes came from MS, could you please comment here ?
More information about the core-libs-dev