RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

Bernhard Urban-Forster burban at openjdk.java.net
Tue Jan 26 16:38:47 UTC 2021

On Tue, 26 Jan 2021 16:07:19 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> src/java.desktop/share/native/libharfbuzz/hb-common.h line 113:
>>> 111: 
>>> 112: #define HB_TAG(c1,c2,c3,c4) ((hb_tag_t)((((uint32_t)(c1)&0xFF)<<24)|(((uint32_t)(c2)&0xFF)<<16)|(((uint32_t)(c3)&0xFF)<<8)|((uint32_t)(c4)&0xFF)))
>>> 113: #define HB_UNTAG(tag)   (char)(((tag)>>24)&0xFF), (char)(((tag)>>16)&0xFF), (char)(((tag)>>8)&0xFF), (char)((tag)&0xFF)
>> I need a robust explanation of these changes.
>> They are not mentioned, nor are they in upstream harfbuzz.
>> Likely these should be pushed to upstream first if there is a reason for them.
> @lewurm This and other harfbuzz changes came from MS, could you please comment here ?

This looks like a merge fix mistake: https://github.com/openjdk/jdk/commit/051357ef977ecab77fa9b2b1e61f94f288e716f9#diff-e3815f37244d076e27feef0c778fb78a4e5691b47db9c92abcb28bb2a9c2865e


PR: https://git.openjdk.java.net/jdk/pull/2200

More information about the core-libs-dev mailing list