RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

Mahendra Chhipa github.com+34924738+mahendrachhipa at openjdk.java.net
Wed Jan 27 23:06:43 UTC 2021

On Tue, 26 Jan 2021 22:55:32 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
>>   Implemented the review comments.
> test/jdk/java/lang/Class/getEnclosingClass/EnclosingClassTest.java line 126:
>> 124:         Path pkg1Dir = Paths.get(SRC_DIR + "/pkg1");
>> 125:         FileUtils.deleteFileTreeWithRetry(pkg1Dir);
>> 126:     }
> I'm not convinced the `@AfterClass` method is necessary.  Pre-cleanup is already done on LL94-95.  And occasionally, test-generated artifacts are helpful in post-mortem analysis.

To keep the source code repo clean from temporary generated files, these files are removed after test. Test logs have the information about the generated files for the Postmortem analysis.


PR: https://git.openjdk.java.net/jdk/pull/2170

More information about the core-libs-dev mailing list