RFR: 8260592: jpackage tests fail when Desktop is not supported

Alexander Matveev almatvee at openjdk.java.net
Fri Jan 29 01:16:41 UTC 2021

On Thu, 28 Jan 2021 23:41:44 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> I would prefer to have separate messages for "headless" and "desktop capable". I can merge these, if you insist.
> Duplicated messages are not much help in understanding control flow. I'd change the new message or merge conditions. Whatever you prefer.

It is fine with me to have two separate messages for display and desktop, but it is better to move this check to top of function after if (GraphicsEnvironment.isHeadless()). No point to execute other code.


PR: https://git.openjdk.java.net/jdk/pull/2291

More information about the core-libs-dev mailing list