RFR: 8260592: jpackage tests fail when Desktop is not supported [v2]

Aleksey Shipilev shade at openjdk.java.net
Fri Jan 29 07:31:55 UTC 2021

On Fri, 29 Jan 2021 01:13:30 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Duplicated messages are not much help in understanding control flow. I'd change the new message or merge conditions. Whatever you prefer.
> It is fine with me to have two separate messages for display and desktop, but it is better to move this check to top of function after if (GraphicsEnvironment.isHeadless()). No point to execute other code.

Okay, I moved the check upwards. The trace message is left intact. Note it says "desktop", there, so it is not a duplicate message.


PR: https://git.openjdk.java.net/jdk/pull/2291

More information about the core-libs-dev mailing list