RFR: 8254702: jpackage app launcher crashes on CentOS [v2]
asemenyuk at openjdk.java.net
Fri Jan 29 23:06:20 UTC 2021
> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702
> The fix splits Linux app launcher in app launcher and launcher shared lib. App launcher is pure C and doesn't have C++ code. App launcher lib incorporates bulk of C++ code from app launcher.
> At startup app launcher loads launcher shared lib and calls functions it provides to get data for launching JVM (path to jli lib and arguments for JLI_Launch function call).
> App launcher unloads launcher shared lib before launching JVM to remove C++ runtime from the process memory.
> Getting rid of C++ code from app launcher required to rewrite app installation location lookup code from C++ to C. LinuxPackage.c source is C alternative for https://github.com/openjdk/jdk/blob/master/src/jdk.jpackage/linux/native/applauncher/Package.cpp and https://github.com/openjdk/jdk/blob/master/src/jdk.jpackage/linux/native/applauncher/Executor.cpp.
> Layout of jpackage's native code changed:
> - `common`: code shared between all jpackage binaries.
> - `applauncher`: launcher only code.
> - `applauncherlib`: launcher lib code on Linux and launcher code on other platforms.
> - `applaunchercommon`: code shared between launcher and launcher lib on Linux and launcher code on other platforms.
Alexey Semenyuk has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
8254702: jpackage app launcher crashes on CentOS
- all: https://git.openjdk.java.net/jdk/pull/2320/files
- new: https://git.openjdk.java.net/jdk/pull/2320/files/14d277a2..b493bcfd
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2320&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2320&range=00-01
Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
Fetch: git fetch https://git.openjdk.java.net/jdk pull/2320/head:pull/2320
More information about the core-libs-dev