RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v6]
alanb at openjdk.java.net
Sun Jan 31 16:32:42 UTC 2021
On Sun, 31 Jan 2021 16:26:58 GMT, Johannes Kuhn <github.com+652983+DasBrain at openjdk.org> wrote:
>> Simple fix - one line change: https://openjdk.github.io/cr/?repo=jdk&pr=2000&range=00#sdiff-0.
>> Most of the changes come from an additional test that fails without this fix:
>> Error: Unable to load main class somelib.test.TestMain in module somelib
>> java.lang.IllegalAccessError: superclass access check failed: class somelib.test.TestMain (in module somelib) cannot access class java.lang.Object (in module java.base) because module java.base does not export java.lang to module somelib
>> As described in JDK-8259395.
>> You can view the output of the test without patch here: https://github.com/DasBrain/jdk/runs/1668078245
>> Thanks to @AlanBateman for pointing out the right fix.
> Johannes Kuhn has updated the pull request incrementally with one additional commit since the last revision:
> Renamed tests, to make it more clear what they should test.
Thanks for the updates.
Marked as reviewed by alanb (Reviewer).
More information about the core-libs-dev