RFR: 8273111: Default timezone should return zone ID if /etc/localtime is valid but not canonicalization on linux
naoto at openjdk.java.net
Wed Sep 1 13:42:50 UTC 2021
On Wed, 1 Sep 2021 06:45:26 GMT, Wu Yan <wuyan at openjdk.org> wrote:
> Please help me review the change to enhance getting time zone ID from /etc/localtime on linux.
> We use `realpath` instead of `readlink` to obtain the link name of /etc/localtime, because `readlink` can only read the value of a symbolic of link, not the canonicalized absolute pathname.
> For example, the value of /etc/localtime is "../usr/share/zoneinfo//Asia/Shanghai", then the linkbuf obtained by `readlink` is "../usr/share/zoneinfo//Asia/Shanghai", and then the call of `getZoneName(linkbuf)` will get "/Asia/Shanghai", not "Asia/Shanghai", which consider as invalid in `ZoneInfoFile.getZoneInfo()`. Using `realpath`, you can get “/usr/share/zoneinfo/Asia/Shanghai“ directly from “/etc/localtime“.
The change looks reasonable. Please test your fix with macOS as well.
More information about the core-libs-dev