RFR: 8273261: Replace 'while' cycles with iterator with enhanced-for in java.base

Daniel Fuchs dfuchs at openjdk.java.net
Thu Sep 2 09:41:30 UTC 2021

On Wed, 1 Sep 2021 07:37:53 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> There are few places in code where manual while loop is used with Iterator to iterate over Collection.
> Instead of manual while cycles it's preferred to use enhanced-for cycle instead: it's less verbose, makes code easier to read and it's less error-prone.
> It doesn't have any performance impact: java compiler generates similar code when compiling enhanced-for cycle.
> Similar cleanups:
> * https://bugs.openjdk.java.net/browse/JDK-8258006
> * https://bugs.openjdk.java.net/browse/JDK-8257912

Generally this looks like a good improvement as the resulting code becomes more readable.
Changes in sun/net or jar index classes look fine. Please obtain approval from maintainers of the other areas before integrating.


Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5328

More information about the core-libs-dev mailing list