RFR: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms [v3]
ccheung at openjdk.java.net
Thu Sep 16 17:51:45 UTC 2021
On Thu, 16 Sep 2021 03:44:24 GMT, Remilia Scarlet <github.com+22913521+1996scarlet at openjdk.org> wrote:
>> The test assumes that it always runs on 64-bit platform and classes_nocoops.jsa is always created.
>> It's a test bug. The test should only expect classes_nocoops.jsa exists if it's running on a supported 64-bit platform.
>> However, for unknown target platform, it's unknown if it's 64-bit or not.
>> This patch fix the test to check if classes_nocoops.jsa exists only on one of the JDK supported platforms (x64 or aarch64) via the sun.arch.data.model system property.
>> Please review this change. Thanks!
> Remilia Scarlet has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms
Marked as reviewed by ccheung (Reviewer).
The fix in the test case seems fine to me.
We'll file a follow-up bug to fix the `jdk.test.lib.Platform::isDefaultCDSArchiveSupported` method and may re-fix the test case then.
More information about the core-libs-dev