RFR: 8272600: (test) Use native "sleep" in Basic.java [v5]

Bernd Eckenfels ecki at zusammenkunft.net
Thu Sep 16 21:51:48 UTC 2021

I like it, but I think you don’t Need the %n linebreak (at least the other fail message has none)

Von: core-libs-dev <core-libs-dev-retn at openjdk.java.net> im Auftrag von Roger Riggs <rriggs at openjdk.java.net>
Gesendet: Donnerstag, September 16, 2021 6:13 PM
An: core-libs-dev at openjdk.java.net
Betreff: Re: RFR: 8272600: (test) Use native "sleep" in Basic.java [v5]

> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified unexpected messages from a child Java VM
> as the cause of the test failure.  Attempts to control the output of the child VM have failed, the VM is unrepentant .
> There is no functionality in the child except to wait long enough for the test to finish and the child is destroyed.
> The fix is to switch from using a Java child to using a native child; a new executable `sleepmillis`.

Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

  Improve diagnostic message to add the exit value of the process.
  The test will fail if the process has terminated early.
  (It would have failed anyway due to too short wait).


  - all: https://git.openjdk.java.net/jdk/pull/5239/files
  - new: https://git.openjdk.java.net/jdk/pull/5239/files/2a9c33fb..43a54802

 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5239&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5239&range=03-04

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5239.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5239/head:pull/5239

PR: https://git.openjdk.java.net/jdk/pull/5239

More information about the core-libs-dev mailing list