RFR: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms [v4]

Mandy Chung mchung at openjdk.java.net
Fri Sep 17 01:55:51 UTC 2021

On Fri, 17 Sep 2021 01:47:05 GMT, Remilia Scarlet <github.com+22913521+1996scarlet at openjdk.org> wrote:

>> The test assumes that it always runs on 64-bit platform and classes_nocoops.jsa is always created.
>> It's a test bug. The test should only expect classes_nocoops.jsa exists if it's running on a supported 64-bit platform.
>> However, for unknown target platform, it's unknown if it's 64-bit or not.
>> This patch fix the test to check if classes_nocoops.jsa exists only on one of the JDK supported platforms (x64 or aarch64) via the sun.arch.data.model system property.
>> Please review this change. Thanks!
> Remilia Scarlet has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

test/jdk/tools/jlink/plugins/CDSPluginTest.java line 82:

> 80:             helper.checkImage(image, module, null, null,
> 81:                       new String[] { subDir + "classes.jsa" });
> 82:         }

The above change checking 64-bit platform should not be needed.    On an unknown platform, `isDefaultCDSArchiveSupported` should return false.  It only returns true on 64-bit supported platforms.   Can you verfiy?


PR: https://git.openjdk.java.net/jdk/pull/5519

More information about the core-libs-dev mailing list