RFR: 8274242: Implement fast-path for ASCII-compatible CharsetEncoders on x86 [v3]
redestad at openjdk.java.net
Tue Sep 28 10:05:05 UTC 2021
On Mon, 27 Sep 2021 12:11:22 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> src/hotspot/share/opto/c2compiler.cpp line 222:
>>> 220: #if !defined(X86)
>>> 221: return false; // not yet implemented
>>> 222: #endif
>> It might be a little more work, but I think it's cleaner to move the decision whether the intrinisc is supported into the Matcher like for most other intrinsics and keep this code here platform independent. Otherwise we will get an increasing cascade of ifdefs as people start implementing this for other platforms.
> Not too much work. I recently introduced platform-specific `matcher_*.hpp` files, so since then adding a boolean constant is easy (no need to muck with the .ad files).
Does the changes in 9800a99 resolve your concerns?
More information about the core-libs-dev