RFR: 8274391: Suppress more warnings on non-serializable non-transient instance fields in java.util.concurrent
dl at openjdk.java.net
Tue Sep 28 11:32:01 UTC 2021
On Mon, 27 Sep 2021 18:40:10 GMT, Joe Darcy <darcy at openjdk.org> wrote:
> Follow-up change to JDK-8232230, augmentations to javac's Xlint:serial checking are out for review (https://github.com/openjdk/jdk/pull/5709) and java.util.concurrent would need some changes to pass under the expanded checks.
> The changes are to suppress warnings where non-transient fields in serializable types are not declared with a type statically known to be serializable. That isn't necessarily a correctness issues, but it does merit further scrutiny.
> In ForkJoinTask, the SuppressWarnings annotation previously applied in JDK-8232230, seems to have been misplaced to a different field; this change corrects it.
Just to be sure, does this include only the conditionally serializable annotations in ForkJoinPool and ForkJoinTask in:
If so, this looks OK to me.
More information about the core-libs-dev