RFE for webrev: the meaning of -r

John Rose John.Rose at Sun.COM
Tue Feb 24 04:51:09 UTC 2009

On Feb 23, 2009, at 7:10 PM, Max (Weijun) Wang wrote:

> Currently, 'webrev -N -r n' creates a diff from rev n to the working  
> directory. Is this really useful? How about output a diff for the  
> changeset rev=n itself?

It's useful if people don't want to commit their changes before  
reviewing.  (Actually, I use mq to manage my changes, and it does  

> Working on multiple bugs at the moment, I would be very glad to call  
> 'webrev -N -r n' with n=-1,-2,-3... to output a series of webrevs  
> for each changeset I just made.

The mercurial way to say this sort of thing is 123:124, where the  
numbers name two revisions.  Perhaps that can be integrated into  
webrev, although it would touch a couple dozen lines.

-- John

More information about the discuss mailing list