[Audio-engine-dev] Some small Gervill fixes

Mark Wielaard mwielaard at redhat.com
Fri May 9 10:14:28 PDT 2008

Hi Karl,

On Mon, 2008-05-05 at 00:30 +0200, Mark Wielaard wrote:
> > I especially proud of the new AudioFloatFormatConverter, it makes
> > sample rate conversion available via a FormatConversionProvider.
> >     http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4916960
> O wow, very nice. I imported the new Gervill CVS version into IcedTea.

And then I forgot to add the AudioFloatFormatConverter class to the
javax.sound.sampled.spi.FormatConversionProvider file. DOH!

Added that now to the icedtea-gervill.patch and imported a fresh Gervill
CVS into the overlays.

One small nit. AudioFloatFormatConverter.getTargetFormats() happily
tells me that it will convert to lots of AudioFormats even if it doesn't
actually know the given target encoding. I added a check on
isConversionSupported() like the other converter methods do.

2008-05-09  Mark Wielaard  <mwielaard at redhat.com>

    * overlays/openjdk/jdk/src/share/classes/com/sun/media/sound:
    Import Gervill fixes from CVS. See CHANGES.txt.
    Check isConversionSupported() in
    * patches/icedtea-gervill.patch: Add AudioFloatFormatConverter to

AudioFloatFormatConverter patch against Gervill CVS attached.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: AudioFloatFormatConverter.patch
Type: text/x-patch
Size: 998 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20080509/c81cd5e6/AudioFloatFormatConverter.patch 

More information about the distro-pkg-dev mailing list