[rfc][icedtea-web] Move all security dialogues' panels implementation into separate subpackage.

Andrew Azores aazores at redhat.com
Tue Mar 4 22:20:09 UTC 2014

On 02/26/2014 08:59 AM, Jiri Vanek wrote:
> Move all security dialogues' panels implementation into separate 
> subpackage.
> The dialogues are really multiplying, and the package of 
> net/sourceforge/jnlp/security/ is overrun.
> This refactoring is moving all implementations of security dialogues' 
> panels into net/sourceforge/jnlp/security/dialogues/

Yea, this is a good idea. Nit: it should be "dialogs", not "dialogues". 
Dialog is for windows that pop up prompting you for stuff, Dialogue 
means actual conversation between people ;)

> The only real change of code is
> -    protected void setValue(Object value) {
> +    public void setValue(Object value) {
>          OutputController.getLogger().log("Setting value:" + value);
>          this.value = value;
>      }
> in netx/net/sourceforge/jnlp/security/SecurityDialog.java
> Which seems tome better then move 
> netx/net/sourceforge/jnlp/security/SecurityDialog.java to 
> netx/net/sourceforge/jnlp/security/dialogues/SecurityDialog.java

Seems fine to me.

> If somebody cares, this patch is applicable also to 1.4 but backports 
> to Panes are not common. Is anybody for/against the refactoring of 1.4 
> too?
> Best regards from CZ
>   J.

I don't see much point to it, but if you or anyone else want to do it 
then go ahead I suppose.

I'll call this OK to push when the newest added classes are also taken 
into account, and preferably you change the new subpackage name as well. 
Unfortunately I just sent another new dialog out for review before 
getting to this, so that one isn't in the new subpackage either.


Andrew A

More information about the distro-pkg-dev mailing list