[rfc][icedtea-web] manifests attributes Validation Moved To Separate Class

Omair Majid omajid at redhat.com
Fri Mar 21 15:16:39 UTC 2014

* Jiri Vanek <jvanek at redhat.com> [2014-03-21 11:06]:
> uff... This is already pushed, and right now there is really lack of time for unittest.

Can I ask for features to be considered 'incomplete' without unit tests?
You know (more than me) about benefits of testing :)

> As this class is inherently tested by  JNLPFile test, I would rather not insists.

Okay, but unit tests are nice to have as documentation too.

Also, if JNLPFile tests are unit tests, they really should be testing
just JNLPFile only and not another class.

> As for guessCodeBase -  where to move it?

I don't have a good idea about where to put it. If this is only called
from one place, I would leave it as a private method for now.

If it's called from multiple places, please leave it where it is

This is not the cleanest solution, but I think it's a good idea to
demarcate clean libraries as 'clean' and not allow
things-we-are-unsure-about or
methods-that-dont-quite-fit-the-abstraction in there.

> As I told. I wold rather skipp both suggestions rightnow :(

As maintainer, it's your call. I would urge you to reconsider, though.


PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681

More information about the distro-pkg-dev mailing list