[rfc][icedtea-web] cache tweeks

Andrew Azores aazores at redhat.com
Mon Mar 24 15:01:18 UTC 2014

On 03/21/2014 11:30 AM, Jiri Vanek wrote:
> On 03/20/2014 04:23 PM, Andrew Azores wrote:
>> On 03/20/2014 10:32 AM, Jiri Vanek wrote:
>>> releaseLock is bug, found thanx to tweeksToCache work.
>>> releaseLock is releasing the never released lock. It is not 100% fix 
>>> but for deeper fixing this
>>> needs to wait for cache revisite. ntil now it was invisible, because 
>>> jvm always terminated after
>>> clean-cache.
>>> The tweeksToCache is doing the only thing - making clear cache more 
>>> visible. Righ ntnow it exists
>>> only as cmd switch, and as feature in itw-settings->cache->view 
>>> Fiels->delete on by one.
>>> Now one can itw-settings->cache->view Files->delete all.
>>> Delete all is also presented on error dialogs - with tooltip why.
>>> Motivation? - tired to close bugs by "clear cache first please" 
>>> "how" "...:x..." "It started to work"
>>> Thanx!
>>>   J.
>> There's some weird formatting going on in the cache tweaks patch. 
>> invokeLaterDeleteAll,
>> disableButtons, restoreDisabled, and visualCleanCache all have 
>> various indentation issues.
>> Otherwise I think this is okay.
>> Thanks,
> Few more nits to this topic.
>  - improved messages
>  - exception shown to user as "what to do now"
> J.

Looks pretty good, feel free to push after fixing formatting problems 
noted in my last email. Only other nit is catching generic Exception in 
visualCleanCache, but this discussion has been had enough times 
already... :)


Andrew A

More information about the distro-pkg-dev mailing list