[rfc][icedtea-web][policyeditor] Modal PolicyEditor

Andrew Azores aazores at redhat.com
Wed Mar 26 15:52:52 UTC 2014

On 03/26/2014 10:48 AM, Andrew Azores wrote:
> On 03/26/2014 07:31 AM, Jiri Vanek wrote:
>> I think we misunderstood a bit.
>> Attached is an patch doing what I wonted.
>> It is defining interface (I wish it could be an class! :) ) common to 
>> both  PolicyEditorFrame and PolicyEditorDialog.
>> It become quite verbose, but its cleaner.
>> It is fixing one mayor bug:
>> You had     public static class PolicyEditorFrame extends JDialog {
>> So I fixed it to    public static class PolicyEditorFrame extends 
>> JFrame {
>> And making the two constructors I wont private.
>> I really don't know where we miscommunicated:))
>> Also it is removing unnecessary    private final Window parentWindow 
>> by fixing the signature of methods which were using from incorrect 
>> window, to correct component.
>> Otherwise it is same. If  you can survive my Interface, You can push.
>> If not (and I agree it is maybe nuclear shot to kill a pigeon.. 
>> really maybe to much verbose) then please one last round. But keep 
>> your version :
>>  - with two private constructors
>>  - without aprent variable
>>  - and without duplicate code.
>> Sorry for my probably wrong explanations during reviews :(
>> J.
> Wow, yes quite verbose. But it seems like a good enough solution. I'll 
> push this then.
> Thanks,

As discussed on IRC, some flaws were found with this. This patch fixes 
the known problems at least. The "Save Changes" prompt now works 
properly again, and the checkbox labels and remove button are now the 
correct widths.


Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: modal-policyeditor-fixes.patch
Type: text/x-patch
Size: 9456 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20140326/7218472c/modal-policyeditor-fixes.patch>

More information about the distro-pkg-dev mailing list