[icedtea-web] RFC: Use AC_LANG_SOURCE macros

Omair Majid omajid at redhat.com
Mon Mar 31 13:34:33 UTC 2014

Hi Jiri,

* Jiri Vanek <jvanek at redhat.com> [2014-03-31 08:48]:
> On 03/28/2014 06:49 PM, Omair Majid wrote:
> >The attached patch fixes the warning by wrapping the code in an
> >AC_LANG_SOURCE macro.
> If you check  , you will see that I'm aware of it :)

Whoops, I must have missed that.

> I was afraid to fix it for 1.5 because I was not able to find, when
> ac_lang_source appeared in autotools. I was afraid to break some
> older systems where ITW can appear.

That's certainly a good reason.

It's a little incorrect, though. The configure.ac to configure
conversion is done by the maintainer (you) on your local machine on
release. The icedtea-web release tarball will contain a generated
configure script. This configure script is sufficient for use by
everyone building icedtea-web from the release tarball. There should be
no need for anyone to process configure.ac locally. Even if
AC_LANG_SOURCE was a new thing, it wouldn't matter.


PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681

More information about the distro-pkg-dev mailing list