[icedtea-web] RFC: Handle a requested heap size of '1g'

Andrew Azores aazores at redhat.com
Mon Mar 31 13:41:56 UTC 2014

On 03/31/2014 09:33 AM, Jiri Vanek wrote:
> On 03/28/2014 10:44 PM, Omair Majid wrote:
>> Hi,
>> I just ran across this jnlp file: 
>> http://atlaslivecasino.net/casino_game.jnlp
>> This fails to work with HEAD because the application asks for a heap
>> size of '1G'. This is not a regression.
>> The attached patch fixes it.
>> Thanks,
>> Omair
> What about t and T ? O:)
> I do not wont to be nitpicker, but I think this code desreves a bit 
> more refactoring>
> Eg the one attached?
> Feel free to push anyone you like more.
> ps: please jsut keep the  JREDesc a =  in tests. It removed NB warning.

I like the regexes better as well, although to nitpick, couldn't "{0,1}" 
be replaced by "?" ;) the regex pattern could also be stored as a 
constant and unit tested on its own as well, rather than changing the 
visibility of this method.

Just some suggestions, I'm happy enough with the original patch.


Andrew A

More information about the distro-pkg-dev mailing list