RFR(M): Graal PTX enhancements

Christian Thalinger christian.thalinger at oracle.com
Fri Apr 5 14:42:55 PDT 2013

On Apr 5, 2013, at 10:46 AM, Morris Meyer <morris.meyer at oracle.com> wrote:

> Folks,
> Could I get a review of my recent PTX enhancements to Graal?   I've changed the tests to have a base class, extended the assembler, and have taken the test coverage of PTX from 2 to 23 tests.
> Thanks in advance,
>        --morris meyer
> WEBREV - http://cr.openjdk.java.net/~morris/Graal-PTX-Enhancements.01

This is great!

Looking at:


it seems we need to turn off "Organize imports" in our favorite editor.  Also indenting seems to be an issue.

I know the answer is "use the mx script to create the IDE configuration" but no everybody is using Eclipse or Netbeans.  We need to find a way to keep this consistent without the help of an IDE (maybe Mercurial push hooks?).


Can we name the test base class PTXTestBase?

Otherwise this looks good to me.

-- Chris

More information about the graal-dev mailing list