Small change to build Graal with Lambda repo
doug.simon at oracle.com
Fri Apr 26 12:12:59 PDT 2013
I've applied the patch and pushed it to the internal repository. I'll propagate it to the OpenJDK repo now.
On Apr 26, 2013, at 9:10 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> On Apr 26, 2013, at 7:26 AM, Doug Simon <doug.simon at oracle.com> wrote:
>> On Apr 26, 2013, at 3:52 PM, "Caspole, Eric" <Eric.Caspole at amd.com> wrote:
>>> Hi everybody,
>>> I have been experimenting to build Graal against the jdk 8 lambda tip repo. It seems the args for sun.reflect.Reflection.getCallerClass() changed between JDK 7 and 8.
>>> This one line change allows the build to succeed and I can use this JDK 8 Graal build in NetBeans to run the Junits.
>>> I am not sure there is a JDK 8 branch for Graal, can this be integrated without breaking JDK 7?
>> I don't think so. However, if this is the only thing preventing one using the latest JDK 8, I vote we just delete the test.
> Yes, we should remove the test because it's an internal API that can be changed any time. For that exact same reason I didn't add a test for:
> GRAAL-246: intrinsify Reflection.getCallerClass
> -- Chris
>> The alternative is to use a bunch of reflection to make the right call based on the underlying JDK which kind of defeats the intention of the JTT tests which should only stress a limited number of features.
More information about the graal-dev