[PATCH] fix invalid suffix on literal compilation errors with graal-jvmci-8

Doug Simon doug.simon at oracle.com
Mon May 16 12:57:43 UTC 2016

Hi Mauro,

Thanks for the patch. The JVMCI code in GraalVM is based on upstream hotspot repositories so we follow the coding guidelines established for the HotSpot code base. As far as I understand, the HotSpot group has not adopted C++11 and until they do, we need to stick with the current style.

That said, we are in the process of moving away from JVMCI as a suite dependency and towards providing JDK binaries that include JVMCI. For JDK8, this means we will be providing binary bundles (location yet to be determined). For JDK9, one will simply download a binary from https://jdk9.java.net/download/.


> On 16 May 2016, at 13:55, Tortonesi Mauro <mauro.tortonesi at unife.it> wrote:
> Dear GraalVM developers,
> I am writing you because I have been trying to compile GraalVM on this machine:
> remus graal/jvmci gcc --version
> gcc (GCC) 6.1.1 20160501
> Copyright (C) 2016 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> remus graal/jvmci uname -a
> Linux remus.endif.man 4.4.5-1-ARCH #1 SMP PREEMPT Thu Mar 10 07:38:19
> CET 2016 x86_64 GNU/Linux
> and encountered several compilation errors with graal-jvmci-8.
> I am sending you in attachment a patch that gets rid of numerous
> "invalid suffix on literal; C++11 requires a space between literal and
> string macro [-Werror=literal-suffix]" compilation errors.
> Best regards,
> Mauro Tortonesi
> -- 
> Mauro Tortonesi, Ph.D.
> Assistant Professor
> Distributed Systems Research Group
> Engineering Department
> University of Ferrara
> <graal-jvmci-8-suffix-literals-20160516.patch>

More information about the graal-dev mailing list