Missing membar for constructors
doug.simon at oracle.com
Fri Nov 11 13:35:02 UTC 2016
I created a short screen recording of the process for cloning graal-core and submitting a pull request:
> On 11 Nov 2016, at 13:23, Benoit Daloze <eregontp at gmail.com> wrote:
> Hello Andrew,
> in your local git clone of graal-core, you can do:
> # Creates the branch and switches to it
> $ git checkout -b final_membar
> # Create a commit of the changes
> $ git commit -av
> Now you need to click "Fork" on https://github.com/graalvm/graal-core.
> Once done, get your repository URL under "Clone or download".
> $ git remote add mine <URL>
> $ git push -u mine final_membar
> Go to https://github.com/graalvm/graal-core and create a Pull Request
> (there should be a green button "Compare and create Pull Request" to do it
> Hope it helps,
> On Fri, Nov 11, 2016 at 10:35 AM, Andrew Haley <aph at redhat.com> wrote:
>> On 10/11/16 20:56, Doug Simon wrote:
>>> The github documentation is fairly comprehensive but if you have any
>>> questions, feel free to ask here or in the graal-core Gitter room
>> Okay. It all sounds amazingly complicated, but I guess it can't be as
>> bad as it seems or people wouldn't use GitHub.
>> I think I have to:
>> Create a branch in the Graal repo on GitHub
>> Push my change to it
>> Create a new pull request
>> Is that right?
>> Some questions arise in my mind. Should this newly-created branch be
>> unique to this bug? What sort of name should it have? What branch
>> should this pull request be based on?
>> It would help me tremendously if someone could talk me through the
>> creation of this branch.
More information about the graal-dev