Missing membar for constructors

Doug Simon doug.simon at oracle.com
Fri Nov 11 13:39:59 UTC 2016

> On 11 Nov 2016, at 10:35, Andrew Haley <aph at redhat.com> wrote:
> On 10/11/16 20:56, Doug Simon wrote:
>> The github documentation is fairly comprehensive but if you have any
>> questions, feel free to ask here or in the graal-core Gitter room
>> (https://gitter.im/graalvm/graal-core).
> Okay.  It all sounds amazingly complicated, but I guess it can't be as
> bad as it seems or people wouldn't use GitHub.
> I think I have to:
>  Create a branch in the Graal repo on GitHub
>  Push my change to it
>  Create a new pull request
> Is that right?
> Some questions arise in my mind.  Should this newly-created branch be
> unique to this bug?

Yes. Branches in git are typically short lived and represent a single logical item of work (that can be made up of more than one commit).

Once your branch is merged into the master branch, you (typically) delete the branch on your fork:

> git branch -d final_membar

>  What sort of name should it have?

Something short like Benoit suggested.

>  What branch
> should this pull request be based on?

On the master branch.

> It would help me tremendously if someone could talk me through the
> creation of this branch.

Sure. Let us know if you have further questions.


More information about the graal-dev mailing list