RFR: JDK-8221341 - Update Graal

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Mar 28 17:48:05 UTC 2019

On 3/28/19 12:37 AM, jesper.wilhelmsson at oracle.com wrote:
> Hi,
> Please review the patch to integrate the latest Graal changes into OpenJDK.
> Graal tip to integrate: 7970bd76ff60600ab5a2fc96cd24ddd7ed017cf8
> JBS duplicates fixed by this integration:
> https://bugs.openjdk.java.net/browse/JDK-8220643
> https://bugs.openjdk.java.net/browse/JDK-8220810
> JBS duplicates deferred to the next integration:
> https://bugs.openjdk.java.net/browse/JDK-8214947

We should investigate why this bug is still referenced in RFR. We already discussed it:

> Bug: https://bugs.openjdk.java.net/browse/JDK-8221341
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8221341/webrev.00/

We also discussed indentation change in make/test/JtregGraalUnit.gmk
Why the change showed up again?

Otherwise changes looks good.

Doug, it is good to have only one Graal class to access Unsafe class - GraalUnsafeAccess.java.
But we should not use sun.misc.Unsafe in JDK 13 - we should have version for JDK9+ which use 
jdk.internal.misc.Unsafe. It is for an other update.


> Thanks,
> /Jesper

More information about the graal-dev mailing list