Request for review (XL): 6822110: Add AddressLiteral class on SPARC

Tom Rodriguez Thomas.Rodriguez at Sun.COM
Fri Apr 17 11:58:07 PDT 2009

The changes look ok, though there's a lot of renaming of Address a to  
Address a1 which isn't really an improvement.


On Apr 16, 2009, at 8:34 AM, Christian Thalinger wrote:

> On Wed, 2009-04-01 at 21:40 +0200, Christian Thalinger wrote:
>>> assembler_sparc.hpp:
>>> why does load_contents take 2 registers?  All uses pass the same  
>>> thing
>>> for both.  It should just assume the dest is the temp.  Actually I
>>> think that's true of all the new ones that take both a temp and a  
>>> dest.
>> That sounds reasonable.  I will change that.
> Finally I found the bugs I had in my changes and here is the third,  
> and
> hopefully final, webrev:
> I tested the changes with JPRT, DaCapo and SPECjvm2008.
> -- Christian

More information about the hotspot-compiler-dev mailing list