Request for review (XL): 6822110: Add AddressLiteral class on SPARC
Thomas.Rodriguez at Sun.COM
Mon Apr 20 09:52:14 PDT 2009
On Apr 19, 2009, at 12:54 PM, Christian Thalinger wrote:
> On Fri, 2009-04-17 at 11:58 -0700, Tom Rodriguez wrote:
>> The changes look ok, though there's a lot of renaming of Address a to
>> Address a1 which isn't really an improvement.
> Should I revert them? I thought it's helpful to have a variable name
> that is different to the a for Address one before, al for
The al looked like a1 to me which just seemed odd. Going from one
character to two doesn't do much for understanding so I'd either
revert it or use something longer, like addrlit. Whatever you want to
do is fine.
> -- Christian
More information about the hotspot-compiler-dev