review (S) for 6862863: C2 compiler fails in elide_copy()

Vladimir Kozlov Vladimir.Kozlov at Sun.COM
Tue Aug 11 21:49:03 PDT 2009

Tom Rodriguez wrote:

Few questions:

Why yank_if_dead() checks only in(1) if it is also dead
and not other inputs which could be dead also after old
node is removed? should we fix it?

Also from the current code it is not clear that at the end
it does next for this nreg:


(and corresponding nreg_lo mapping for register pair).
May be it needs additional comment in your changes.

Also in the new method you use "regnd->at(nreg)"
when in other places regnd and value are passed as
references and "regnd[nreg]". Can you do the same?


More information about the hotspot-compiler-dev mailing list