Request for reviews (M): 6833129 : specjvm98 fails with NullPointerException in the compiler with -XX:DeoptimizeALot

John Rose John.Rose at Sun.COM
Mon Jul 6 22:52:56 PDT 2009

On Jul 6, 2009, at 5:21 PM, changpeng fang - Sun Microsystems - Santa  
Clara United States wrote:


Here's a nit:  is_restart() in scopeDesc.hpp should be a const function.

I'd like to see comment in each case demonstrating why that the values  
captured in dummy_restart, and the throwaway restart in  
javaClasses.cpp (which should be called dummy_restart also) don't  

I'd still like to see the restart decision made by continuation_for  
turned into an assert.  At least compare it with is_restart():

>    pc = Interpreter::continuation_for(method(), bcp,  
> callee_parameters, is_top_frame, use_next_mdp);
> + assert(is_restart() == !use_next_mdp, "");

If the assert fails, there may be a bug.

-- John

More information about the hotspot-compiler-dev mailing list