Request for review (M): 6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post
Thomas.Rodriguez at Sun.COM
Wed Jul 15 12:07:30 PDT 2009
The test is missing the copyright notice but otherwise this looks
good. BTW, I ran a full ctw with this change both as is and as an
assert that checked for cases where this would produce a different
control and I only found 4 cases where it ever changed the answer and
none of those triggered a failure in the way the test case does.
Hiroshi, thanks for tracking this down and Chuck, thanks for
distilling a test case.
On Jul 15, 2009, at 9:27 AM, Chuck Rasbold wrote:
> Fixed 6860469: remix_address_expressions sets incorrect control
> causing crash in split_if_with_block_post
> Consult the control node of both inputs when deciding where to place
> new LShiftI node.
> Previously, we assumed the invar input should set the new node's
> control, and the scale input was irrelevant for control's sake.
> However, sometimes the invar input is a constant, allowing it to be
> higher in the dom tree than the scale.
> Fix provided by Hiroshi Yamauchi (yamauchi at google.com)
More information about the hotspot-compiler-dev